Debugging doctest failure #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue appears to be that an old (2016) version of certifi is installed with Python 3.6. I guess it's a pinned dependency, because a conda update doesn't update the version. I think it should be fine if we use Python 3.8 for doctests instead, which comes preloaded with a compatible certifi version. |
|
Should be fine for doctests to run on a more recent version of python. Should we add an entry to the changelog? |
manodeep
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting
ERROR: Cannot uninstall 'certifi'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.e.g. here: https://github.com/manodeep/Corrfunc/pull/258/checks?check_run_id=3886102439Not sure why, maybe an environment issue? Opening this PR to debug.